Re: x86 building altivec for raid ?

From: Neil Brown
Date: Sun Nov 13 2005 - 16:26:38 EST


On Sunday November 13, jamagallon@xxxxxxx wrote:
>
> Kernel is 2.6.14-mm2.
> This is an x86 box, why does it compile raid6altivec*.c ? I suppose it
> does not generate any code, because of some #ifdef magic, but why does
> it build them anyways ? Looks a bit strange.

It's probably just easier that way.
I guess you could do the following, but I'm not sure that it is really
worth it.

NeilBrown

Signed-off-by: Neil Brown <neilb@xxxxxxx>

diff ./drivers/md/Makefile~current~ ./drivers/md/Makefile
--- ./drivers/md/Makefile~current~ 2005-11-14 08:13:43.000000000 +1100
+++ ./drivers/md/Makefile 2005-11-14 08:23:29.000000000 +1100
@@ -8,12 +8,15 @@ dm-multipath-objs := dm-hw-handler.o dm-
dm-snapshot-objs := dm-snap.o dm-exception-store.o
dm-mirror-objs := dm-log.o dm-raid1.o
md-mod-objs := md.o bitmap.o
+raid6-$(CONFIG_ALTIVEC) := \
+ raid6altivec1.o raid6altivec2.o raid6altivec4.o \
+ raid6altivec8.o
+raid6-$(CONFIG_X86) := raid6mmx.o raid6sse1.o
+raid6-$(CONFIG_X86_64) := raid6sse2.o
raid6-objs := raid6main.o raid6algos.o raid6recov.o raid6tables.o \
raid6int1.o raid6int2.o raid6int4.o \
raid6int8.o raid6int16.o raid6int32.o \
- raid6altivec1.o raid6altivec2.o raid6altivec4.o \
- raid6altivec8.o \
- raid6mmx.o raid6sse1.o raid6sse2.o
+ $(raid6-y)
hostprogs-y := mktables

# Note: link order is important. All raid personalities

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/