Re: [PATCH] TPM: cleanups

From: Andrew Morton
Date: Sat Nov 12 2005 - 16:49:12 EST


Kylene Jo Hall <kjhall@xxxxxxxxxx> wrote:
>
> + schedule_work(&chip->work);
> +}
> +
> +static void timeout_work(void * ptr)
> +{
> + struct tpm_chip *chip = (struct tpm_chip*) ptr;
> +

I cannot see where the tpm driver stops that timer which it has running on
device close or on module unload.

Wherever it is, we'll now also need a flush_scheduled_work() to avoid a race
wherein the work handler is still executing while the module gets
unloaded.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/