Re: Breakage in net/ipv4/tcp_vegas.c

From: Ian McDonald
Date: Sat Nov 12 2005 - 13:35:27 EST


On 11/12/05, Horst von Brand <vonbrand@xxxxxxxxxxxx> wrote:
> CC [M] net/ipv4/tcp_vegas.o
> net/ipv4/tcp_vegas.c: In function 'tcp_vegas_cong_avoid':
> net/ipv4/tcp_vegas.c:239: error: 'cnt' undeclared (first use in this function)

This has been fixed in the networking tree which I imagine Linus will
merge again soon but here is the fix before then:
Recent TCP changes broke the build.

Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxx>

diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c
index 4376814..b7d296a 100644
--- a/net/ipv4/tcp_vegas.c
+++ b/net/ipv4/tcp_vegas.c
@@ -236,7 +236,7 @@ static void tcp_vegas_cong_avoid(struct
/* We don't have enough RTT samples to do the Vegas
* calculation, so we'll behave like Reno.
*/
- tcp_reno_cong_avoid(sk, ack, seq_rtt, in_flight, cnt);
+ tcp_reno_cong_avoid(sk, ack, seq_rtt, in_flight, flag);
} else {
u32 rtt, target_cwnd, diff;

--
Ian McDonald
http://wand.net.nz/~iam4
WAND Network Research Group
University of Waikato
New Zealand
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/