Re: [2.6 patch] removed useless SCSI_GENERIC_NCR5380_MMIO

From: Alan Cox
Date: Sat Nov 12 2005 - 12:50:53 EST


On Sad, 2005-11-12 at 05:37 +0100, Adrian Bunk wrote:
> This patch removes the useless SCSI_GENERIC_NCR5380_MMIO.
>
> It's useless, since SCSI_G_NCR5380_MEM != CONFIG_SCSI_G_NCR5380_MEM.
>
> This issue exists at least since kernel 2.6.0 and since it seems noone
> noticed it I'd say we can safely remove it.


Its a one line bugfix so make the bugfix. There are often drivers that
needed tiny fixes and it turned out that

- Vendors had it in their patch tree for years
- The one person using it fixed it and didnt bother telling l/k cos they
though l/k was full of arrogant assholes who would just laugh at them
- The few users are still on 2.4 but will move to 2.6

Now when its a major rewrite to fix up some prehistoric piece of crap it
makes sense to dump it if nobody uses it, when you have a one line fix
required its a bit daft not to fix it.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/