Re: [PATCH 2/12] relayfs: export relayfs_create_file() with fileops param

From: Tom Zanussi
Date: Fri Nov 11 2005 - 14:49:34 EST


Christoph Hellwig writes:
> On Fri, Nov 11, 2005 at 10:47:03AM -0600, Tom Zanussi wrote:
> > This patch adds a mandatory fileops param to relayfs_create_file() and
> > exports that function so that clients can use it to create files
> > defined by their own set of file operations, in relayfs. The purpose
> > is to allow relayfs applications to create their own set of 'control'
> > files alongside their relay files in relayfs rather than having to
> > create them in /proc or debugfs for instance. relayfs_create_file()
> > is also used by relay_open_buf() to create the relay files for a
> > channel. In this case, a pointer to relayfs_file_operations is passed
> > in, along with a pointer to the buffer associated with the file.
>
> Again, NACK, control files don't belong into relayfs.
>

Sure, applications could just as easily create these same files in
/proc, /sys, or /debug, but since relayfs is a filesystem, too, it
seems to me to make sense to take advantage of that and allow them to
be created alongside the relay files they're associated with, in
relayfs.

Tom


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/