Re: [PATCH 11/15] misc: Allow dropping panic text strings from kernel image

[Matt Mackall]

On Fri, Nov 11, 2005 at 12:03:25PM +0100, Geert Uytterhoeven wrote:
> On Fri, 11 Nov 2005, Matt Mackall wrote:
> > Index: 2.6.14-misc/kernel/panic.c
> > ===================================================================
> > --- 2.6.14-misc.orig/kernel/panic.c	2005-11-09 11:27:15.000000000 -0800
> > +++ 2.6.14-misc/kernel/panic.c	2005-11-10 23:26:41.000000000 -0800
> > @@ -94,7 +106,11 @@ NORET_TYPE void panic(const char * fmt, 
> >  	smp_send_stop();
> >  #endif
> >  
> > +#ifdef CONFIG_FULL_PANIC
> >  	notifier_call_chain(&panic_notifier_list, 0, buf);
> > +#else
> > +	notifier_call_chain(&panic_notifier_list, 0, "");
> > +#endif
> 
> If you `#define buf ""' above, you can kill this #ifdef.

I don't know that trading an ifdef for a define is an improvement.

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/