Re: [PATCH 8/8] Inline 3 functions

[Adrian Bunk]

On Thu, Nov 10, 2005 at 09:04:20AM -0800, Matthew Dobson wrote:
> Adrian Bunk wrote:
> > 
> >>Well, no, they aren't on the hot path.  I just figured since they are only
> >>ever called from one other function, why not inline them?  If the sentiment
> >>is that it's a BAD idea, I'll drop it.
> > 
> > 
> > And if there will one day be a second caller, noone will remember to 
> > remove the inline...
> 
> So are you suggesting that we don't mark these functions 'inline', or are
> you just pointing out that we'll need to drop the 'inline' if there is ever
> another caller?

I'd suggest to not mark them 'inline'.

> -Matt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/