Re: Broken __get_unaligned from <asm-generic/unaligned.h>

From: Andreas Schwab
Date: Thu Nov 10 2005 - 11:20:14 EST


Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> writes:

> On Thu, Nov 10, 2005 at 03:42:05PM +0100, Andreas Schwab wrote:
>> __get_unaligned can't cope with const-qualified types:
>>
>> drivers/char/vc_screen.c: In function 'vcs_write':
>> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val'
>> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val'
>> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val'
>> drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val'
>
> What if get_unaligned is used with a u64 / long long type (which it is)?

Oops, I missed that, it needs a different approach.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/