Re: [PATCH 12/21] i386 Deprecate descriptor asm

[Vincent Hanquez]

On Mon, Nov 07, 2005 at 08:31:39PM -0800, Zachary Amsden wrote:
> +struct desc_internal_struct {
> +	unsigned short	limit0;
> +	unsigned short	base0;
> +	unsigned char	base1;
> +	unsigned char	type;
> +	unsigned int	limit1 : 4;
> +	unsigned int	flags : 4;
> +	unsigned char	base2;
> +} __attribute__((packed));

just a minor nit,

wouldn't that be better to use u8 and u16 types here ? 

Cheers,
-- 
Vincent Hanquez
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/