Re: [patch] Re: 2.6.14-rc5-mm1 - ide-cs broken!

[Mark Lord]

Richard Purdie wrote:
> - *	FIXME: This treatment is probably applicable for *all* PCMCIA (PC CARD)
> - *	devices, so in linux 2.3.x we should change this to just treat all
> - *	PCMCIA  drives this way, and get rid of the model-name tests below
> - *	(too big of an interface change for 2.4.x).
> - *	At that time, we might also consider parameterizing the timeouts and
> - *	retries, since these are MUCH faster than mechanical drives. -M.Lord
> - */

I believe the latter half of those comments (timeouts) should
be left in the IDE layer (somewhere), as a note to current/future
maintainers about something that does need fixing eventually.

Something like this:

/*
 * FIXME:  Someday we ought to parameterize IDE timeouts to use
 * much smaller values when dealing with flash memory cards.
 * For example, these devices never require more than a second
 * (much less, actually) for "spin-up", compared with a limit
 * of 31 seconds for mechanical ATA drives.  This would speed up
 * error recovery for these popular devices, especially in embedded work
 */

Cheers
-M.Lord
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/