Re: [PATCH 13/39] NLKD/x86-64 - time adjustment

[Vojtech Pavlik]

On Thu, Nov 10, 2005 at 02:19:03PM +0100, Andi Kleen wrote:
 
> Please remove the ifdefs too.  64bit HPET support would be fine, but 
> only as a runtime mechanism, not compile time.
> 
> Can you remove debugger_jiffies please? 
> The code has to handle long delays anyways (e.g. if someone uses a target
> probe), so we cannot rely on such hacks anyways.
> 
> I don't quite understand why the SMP case should be different from UP
> in that ifdef. Can you explain?  It shouldn't in theory.
> 
> 
> /* When the TSC gets reset during AP startup, the code below would
> +			   incorrectly think we lost a huge amount of ticks. */
> That is outdated - the TSCs are not reset anymore since 2.6.12.
> Please remove code for handling that.
> 
> The union in vxtime_data is ugly - can it be avoided?
> 
> Vojtech should probably review that one too when you repost.
 
I'd like to take a look at the patch as it is, but it seems my spam
filter ate it, and LKML.org doesn't archive binary attachments.

I've done some work on making x86-64 time handling overflow save in the
last few days, so I'm quite interested in what you needed to change.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/