Re: [PATCH] backup timer for UARTs that lose interrupts

From: Russell King
Date: Thu Nov 10 2005 - 05:44:13 EST


On Tue, Nov 08, 2005 at 05:16:32PM -0700, Alex Williamson wrote:
> I was hoping that would be the solution too. I just tried enabling
> UART_BUG_TXEN to double check my previous results. Somehow it makes the
> problem much, much worse. Instead of being the nuisance it usually is,
> it seems like the UART gets way behind on transmitting bits. So it
> would probably prevent the unattended reboot stall since we kick it
> every time we want to transmit, but it renders the UART completely
> unusable as a console. I can't even get it caught up enough to login
> via the serial console w/ UART_BUG_TXEN enabled on the port. Thanks,

Ok, would you mind fixing the patch so it isn't screwing up the
default use of up->timer please? You may notice that this timer
is already used, and overwriting up->timer.function is a one-way
process in your patch (which kills off the point of serial8250_timeout).

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/