Re: [PATCH] blk: cfq forced dispatching fix

From: Jens Axboe
Date: Thu Nov 10 2005 - 02:46:24 EST


On Thu, Nov 10 2005, Tejun Heo wrote:
> cfq forced dispatching might not return all requests on the queue.
> This bug can hang elevator switchinig and corrupt request ordering
> during flush sequence.
>
> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
>
> ---
>
> Jens, I implemented a separate code path for forced dispatching as it
> seemed too complex/error-prone to handle forced case in normal
> dispatch path. How do you like this approach?

I like this approach better then mixing the 'force' into various logic
around the function. So applied.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/