[PATCH] Remove read-only check from inode_update_time().

[Anton Altaparmakov]

Hi Andrew,

The read-only check in inode_update_time() (or file_update_time() as it is 
now in -mm) is unnecessary as the VFS better have done all the read-only 
checks and aborted much earlier in the file write code paths where 
inode/file_update_time() is only called from.

(In case you were not following the ntfs discussion, Christoph Hellwig 
agreed that check is unnecessary and can be removed.)

Patch against latest Linus git tree is below, please apply.  If you prefer 
a patch on top of Christoph's file_update_time() check please let me 
know...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

---

The read-only check in inode_update_time() (or file_update_time() as it is
now in -mm) is unnecessary as the VFS better have done all the read-only
checks and aborted much earlier in the file write code paths where
inode/file_update_time() is only called from.

Signed-off-by: Anton Altaparmakov <aia21@xxxxxxxxxx>

--- inode.c	2005-11-09 19:23:35.000000000 +0000
+++ inode.c.new	2005-11-09 22:45:21.000000000 +0000
@@ -1219,8 +1219,6 @@ void inode_update_time(struct inode *ino
 
 	if (IS_NOCMTIME(inode))
 		return;
-	if (IS_RDONLY(inode))
-		return;
 
 	now = current_fs_time(inode->i_sb);
 	if (!timespec_equal(&inode->i_mtime, &now))

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/