Re: [patch] Re: 2.6.14-rc5-mm1 - ide-cs broken!

[Bill Davidsen]

Richard Purdie wrote:
> On Wed, 2005-11-09 at 11:41 -0500, Bill Davidsen wrote:
>
> > Richard Purdie wrote:
> >
> > > This patch stops CompactFlash devices being marked as removable. They
> > > are not removable (as defined by Linux) as the media and device are 
> > > inseparable. When a card is removed, the whole device is removed from 
> > > the system and never sits in a media-less state.
> >
> > Having used CF devices for some years (since RH 8.0) I'm not sure what 
> > problem you're addressing here. Could you describe what problem you're 
> > having, and also note what current functionality this will change?
>
>
> I'll try the explanation once more assuming you failed to understand the
> previous messages in this thread and those linked to in the link I
> provided to a thread about this.

Given the large number of possible valid configurations, I'm trying to 
determine which you are trying to fix and if that will break the others.
> Block devices have a "removable" flag. This flag is defined to indicate
> devices where the media can change. A property of these devices is that
> the device node and device stay around and media may or may not be
> present at any one time. Examples of such devices are floppy and ide cd
> drives.
>
> When you remove a CF card, the controller is removed with the card and
> nothing to do with the CF card or the device exists anymore. They are
> therefore not removable devices in the linux definition of the term.
>
> Currently the removable flag is set for CF cards. This is incorrect as a
> CF device and interface either exists or doesn't. There is no media-less
> state.
>
> This incorrect setting causes loops with udev scripts requiring
> userspace hacks to stop things looping. 
>
> The patch therefore correctly sets the removable flag and removes some
> unneeded code. 
>
> This shouldn't break anything in userspace apart from anything that
> incorrectly interprets the removable flag as being something its not.
There are, at minimum, three possible hardware attach cases, each of 
which may be on a distribution which uses udev or not. I'm assuming that 
if this is a udev problem is would be fixed at the udev level, but your 
comment on "userspace hacks" does sound like fixes to userspace bugs.

The three attach methods are pcmcia, direct plugin slots (laptops only 
AFAIK), and USB devices.

It seems that the pcmcia cases for laptops and desktops are the same, 
and the whole media and device go away as a unit with the card. But for 
USB and direct plug-in, the "device" seems to be present even without 
media. I can't easily check that for laptop before tonight, but attached 
USB devices show up as sdX currently, with or without media. That's on 
an older kernel, I'll check 2.6.13 tonight.
--
   -bill davidsen (davidsen@xxxxxxx)
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/