Re: PATCH: libata PATA patches

[Alan Cox]

On Mer, 2005-11-09 at 16:31 +0300, Sergei Shtylylov wrote:
>     I found somewhat strange that you check for 0xABCDExxx signature in 32-bit 
> PCI config. reg. 0x78 while HighPoint's own drivers read BM reg. 0x90 (i.e. 
> PCI config. 0x70) for that. PCI reg. 0x7A is DPLL precision adjust reg. and 
> 0x7B is the input clock select and IRQ reg., so it'd be quite strange if the 
> BIOS used them for any kind of signature...

Yeah thats a bug. What I get for reading the comments in the old driver
and not double checking against the HPT reference code. Thanks

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/