Re: Changing MSI to use physical delivery mode always.

From: Andi Kleen
Date: Wed Nov 09 2005 - 08:57:06 EST


On Tue, Nov 08, 2005 at 07:00:38AM -0800, Ashok Raj wrote:
> Hi,
>
> MSI was hard coded to use logical delivery mode for i386/x86_64 and
> physical mode for ia64.
>
> With recent x86_64 we moved to physical flat mode that broke MSI.
>
> Made MSI to work with physical mode, this will be consistent on all
> archs.

Nasty bug. Thanks for tracking that down.

It is outright scary though that such deeply architecture specific
code is in drivers/pci. It should be in arch. I think that was
because I missed it. Would you be willing to move the APIC specific parts
to arch/i386/pci ?

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/