Re: [PATCH 5/8] Direct Migration V2: upgrade MPOL_MF_MOVE and sys_migrate_pages()

[KAMEZAWA Hiroyuki]

Christoph Lameter wrote:
> +	err = migrate_pages(pagelist, &newlist, &moved, &failed);
> +
> +	putback_lru_pages(&moved);	/* Call release pages instead ?? */
> +
> +	if (err >= 0 && list_empty(&newlist) && !list_empty(pagelist))
> +		goto redo;


Here, list_empty(&newlist) is needed ?
For checking permanent failure case, list_empty(&failed) looks better.

-- Kame


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/