Re: [PATCH 8/8] Inline 3 functions

From: Christoph Lameter
Date: Tue Nov 08 2005 - 13:59:49 EST


On Tue, 8 Nov 2005, Pekka J Enberg wrote:

> On Mon, 7 Nov 2005, Matthew Dobson wrote:
> > I found three functions in slab.c that have only 1 caller (kmem_getpages,
> > alloc_slabmgmt, and set_slab_attr), so let's inline them.
>
> Why? They aren't on the hot path and I don't see how this is an
> improvement...

It avoids the call/return sequences so it may decrease code size a bit and
allow the compiler (if its up to the task) to do more CSE optimizations.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/