Re: [Patch 1/1] V4L (926) Saa7134 alsa can only be autoloaded after saa7134 is active

From: Takashi Iwai
Date: Tue Nov 08 2005 - 08:20:08 EST


At Tue, 08 Nov 2005 12:07:50 +0000,
R C wrote:
>
> On Tue, 2005-11-08 at 12:36 +0100, Takashi Iwai wrote:
> [...]
>
> > Note that "goto done" may
> > require the lock again. Also, the succeeding saa7134_dma_stop() is
> > superfluous.
> >
>
> No, it's not. dma_stop also affects the main saa7134 module, and it's
> needed there.

But saa7134_dma_stop() should be already called in trigger callback,
which is called via snd_pcm_stop().


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/