Re: [PATCH] slightly enhance cross builds

From: Jan Beulich
Date: Tue Nov 08 2005 - 02:50:20 EST


>>> Sam Ravnborg <sam@xxxxxxxxxxxx> 08.11.05 00:04:26 >>>
>On Mon, Nov 07, 2005 at 01:58:46PM +0100, Jan Beulich wrote:
>> This adds functionality to default CROSS_COMPILE to a sensible
value
>> when cross-building (so one doesn't always have to specify this on
the
>> make command line), as well as storing ARCH and SUBARCH in the
>> Makefile
>> generated when building outside of the source directory (so that
>> subsequent make invocations don't have to always repeat these).
>
>This patch introduce different behaviour with and without make O=
>This will result on confusion and is bad.

Though I admit that I never build inside the source tree, I can't see
what you apparently do. Where/how would the behavior differ? If you just
mean the fact that in-source-tree builds will need to continue to
specify ARCH/SUBARCH on the make command line, then of course yes, this
is going to be different. But building in the source tree is a bad idea
in general in my opinion, and hence I would view this as the price you
pay. Of course this information could be stored in a hidden file in the
output tree (rather than in mkmakefile itself) if that's more
desirable...

>The right approach is to come up with a patch that works in both
cases.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/