Re: [PATCH] use ptrace_get_task_struct in various places

[Andrew Morton]

Christoph Hellwig <hch@xxxxxx> wrote:
>
> The ptrace_get_task_struct() helper that I added as part of the ptrace
> consolidation is usefull in variety of places that currently opencode
> it.  Switch them to the common helper.

If we're going to export ptrace_get_task_struct() to the world it would be
nice to document it too - things like returning zero and a NULL *childp is
a little obscure.

The change breaks ALLOW_INIT_TRACING in sparc32 and sparc64.  I don't know
if that matters.  If (presumably) not, there are cleanups left over.

In arch/ia64/ia32/sys_ia32.c this patch will cause PTRACE_TRACEME requests
to be handled by ptrace_request() rather than by sys_ptrace(), which is a
not-obviously-correct change.

Was the omission of arch/ia64/kernel/ptrace.c:sys_ptrace() deliberate?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/