Re: [PATCH 4/8] Cleanup kmem_cache_create()

From: Roland Dreier
Date: Mon Nov 07 2005 - 21:15:10 EST


> * Replace a constant (4096) with what it represents (PAGE_SIZE)

This seems dangerous. I don't pretend to understand the slab code,
but the current code works on architectures with PAGE_SIZE != 4096.
Are you sure this change is correct?

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/