Re: [PATCH 2/7]: Revised [PATCH 27/42]: SCSI: add PCI error recovery to IPR dev driver

[linas]

On Mon, Nov 07, 2005 at 03:40:32PM -0600, Brian King was heard to remark:
> linas wrote:
> > +/** ipr_eeh_slot_reset - called when pci slot has been reset.
> > + *
> > + * This routine is called by the pci error recovery recovery
> > + * code after the PCI slot has been reset, just before we
> > + * should resume normal operations.
> > + */
> > +static pers_result_t ipr_eeh_slot_reset(struct pci_dev *pdev)
> > +{
> > +	unsigned long flags = 0;
> > +	struct ipr_ioa_cfg *ioa_cfg = pci_get_drvdata(pdev);
> > +
> > +	// pci_enable_device(pdev);
> > +	// pci_set_master(pdev);
> 
> I assume you want remove these two lines... The pci config space
> restore in ipr's reset handling should cover them.

Yes, I do. Its cruft left over from old test and debug cycles. :(

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/