Re: Fwd: [RFC] IRQ type flags

From: Alan Cox
Date: Sun Nov 06 2005 - 18:33:39 EST


On Sul, 2005-11-06 at 22:42 +0000, Russell King wrote:
> We could do as you suggest, but my concern would be adding extra
> complexity to drivers, causing them to do something like:
>
> ret = request_irq(..., SA_TRIGGER_HIGH, ...);
> if (ret == -E<whatever>)
> ret = request_irq(..., SA_TRIGGER_RISING, ...);
>
> The alternative is:
>
> ret = request_irq(..., SA_TRIGGER_HIGH | SA_TRIGGER_RISING, ...);

I was thinking that specifying neither would imply 'don't care' or
'system default'. That would mean existing drivers just worked and
driver authors who didnt care need take no specific action.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/