Re: swsusp not able to stop tasks

From: Pavel Machek
Date: Sun Nov 06 2005 - 16:41:38 EST


Hi!

> >>>What is this kauditd? Try turning auditing off in kernel config, and
> >>>it should go away. If it does, add try_to_freeze() at place where
> >>>sleep is possible into kauditd...
> >>>
> >>That it did. And the machine suspends fine with audit removed. I'll have
> >>a look at inserting those try_to_freeze().
> >>
> >
> >Good.

> The following did the trick:

Looks good to me. I'm not sure, but whitespace looks slightly wrong to
me. Can you write changelog, sign it off, add my acked-by, and send it
to akpm?

Pavel

> diff --git a/kernel/audit.c b/kernel/audit.c
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -291,8 +291,10 @@ int kauditd_thread(void *dummy)
> set_current_state(TASK_INTERRUPTIBLE);
> add_wait_queue(&kauditd_wait, &wait);
>
> - if (!skb_queue_len(&audit_skb_queue))
> + if (!skb_queue_len(&audit_skb_queue)) {
> + try_to_freeze();
> schedule();
> + }
>
> __set_current_state(TASK_RUNNING);
> remove_wait_queue(&kauditd_wait, &wait);

--
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/