Re: PATCH: fix-readonly-policy-use-and-floppy-ro-rw-status

[Jon Masters]

On 11/5/05, Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:

> On Sat, Nov 05, 2005 at 10:33:58AM -0800, Andrew Morton wrote:
> > Jon Masters <jonathan@xxxxxxxxxxxxxx> wrote:
> > >
> > > [PATCH]: This modifies the gendisk and hd_struct structs to replace "policy"
> > >  with "readonly" (as that's the only use for this field).

> ... for now.  IOW, NAK on that part - it's *not* a boolean and it's
> intended to be used for e.g control of caching behaviour.  Stuff
> like "mark it r/o for now without losing information about hw situation"
> also should go there.

But it's not being used for that. The only *uses* I've seen of it
suggest that people are assuming it is a readonly marker.

If you *want* it to be used for such purposes, would you rather I sent
another patch that actually introduced read/write flags to make this
more obvious (if we must keep the existing field around)?

Jon.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/