Re: [PATCH] hfsplus: don't modify journaled volume

[Anton Altaparmakov]

On Fri, 4 Nov 2005, Andrew Morton wrote:
> Roman Zippel <zippel@xxxxxxxxxxxxxx> wrote:
> >
> > +		} else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
> >  +			printk("HFS+-fs: Filesystem is marked journaled, leaving read-only.\n");
> >  +			sb->s_flags |= MS_RDONLY;
> >  +			*flags |= MS_RDONLY;
> 
> These sorts of printks should have an explicit facility level, no?

I would agree with that and further, is that not a bit draconian?  
HFSPlus is designed to work without the journal.  Just change the last 
mounted version to FSK! (0x46534b21) and everything will work as expected, 
i.e. fsck will run a check instead of ignoring the volume and osx will 
mount the volume and reinitialize the journal.  Remember older OSX 
versions did not support journalling so if you attached your external 
drive to one of those older osx boxes, you would also get non-journalled 
writes to a journalled volume.  It's all designed for it...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/