Re: [PATCH resubmit] do_mount: reduce stack consumption

From: Arjan van de Ven
Date: Fri Nov 04 2005 - 12:45:33 EST


On Fri, Nov 04, 2005 at 09:42:12AM -0800, Andrew Morton wrote:
> Andreas Herrmann <AHERRMAN@xxxxxxxxxx> wrote:
> >
> > Obviously you missed the point that (depending on the compiler version,
> > options etc.) do_move_mount() and do_add_mount() can be inlined.
>
> I think we found a way of preventing the 3.x compiler from doing that. Arjan,
> do you recall where we ended up with that problem?

it was mostly caused by -funit-at-a-time that caused 3.x to go haywire. You
need to turn that off in general.

the real fix is in gcc 4.x (4.1 at least) where gcc got a lot smarter about
stack slot lifetimes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/