Re: [RFC,PATCH] libfs dcache_readdir() and dcache_dir_lseek() bugfix

From: Miklos Szeredi
Date: Fri Nov 04 2005 - 08:32:10 EST


> As I said: "Old glibc implementations (e.g. glibc-2.2.5) are
> lseeking after every call to getdents() ..."

Hmm, why would it do that? This seems like it's glibc being stupid.

That said, you are right that the libfs readdir implementation is not
strictly standards conforming. But neither is your patch: this
algorithm will break if the entry at the current position is removed
and then a new entry with the same name is created.

> Precisely this is a SLES8 on s390-64bit.
> s390vm02:/# rpm -qf /bin/rm
> fileutils-4.1.11-144
> s390vm02:/# rpm -q glibc
> glibc-2.2.5-234
>
> But you can also try my testcase.

Unfortunately I can't since I don't have such old glibc.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/