[2.6 patch] drivers/input/: possible cleanups

From: Adrian Bunk
Date: Fri Nov 04 2005 - 07:36:04 EST


This patch contains the following possible cleanups:
- make needlessly glbal code static
- gameport/gameport: #if 0 the unused global function gameport_reconnect


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

drivers/input/gameport/gameport.c | 2 ++
drivers/input/joystick/twidjoy.c | 4 ++--
drivers/input/touchscreen/mk712.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)

--- linux-2.6.14-rc5-mm1-full/drivers/input/joystick/twidjoy.c.old 2005-11-04 11:37:38.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/input/joystick/twidjoy.c 2005-11-04 11:38:01.000000000 +0100
@@ -265,13 +265,13 @@
* The functions for inserting/removing us as a module.
*/

-int __init twidjoy_init(void)
+static int __init twidjoy_init(void)
{
serio_register_driver(&twidjoy_drv);
return 0;
}

-void __exit twidjoy_exit(void)
+static void __exit twidjoy_exit(void)
{
serio_unregister_driver(&twidjoy_drv);
}
--- linux-2.6.14-rc5-mm1-full/drivers/input/touchscreen/mk712.c.old 2005-11-04 11:38:20.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/input/touchscreen/mk712.c 2005-11-04 11:38:29.000000000 +0100
@@ -154,7 +154,7 @@
spin_unlock_irqrestore(&mk712_lock, flags);
}

-int __init mk712_init(void)
+static int __init mk712_init(void)
{
int err;

--- linux-2.6.14-rc5-mm1-full/drivers/input/gameport/gameport.c.old 2005-11-04 11:38:52.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/input/gameport/gameport.c 2005-11-04 11:39:32.000000000 +0100
@@ -637,10 +637,12 @@
gameport_queue_event(gameport, NULL, GAMEPORT_RESCAN);
}

+#if 0
void gameport_reconnect(struct gameport *gameport)
{
gameport_queue_event(gameport, NULL, GAMEPORT_RECONNECT);
}
+#endif /* 0 */

/*
* Submits register request to kgameportd for subsequent execution.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/