Re: [Patch] add AOP_TRUNCATED_PAGE, prepend AOP_ toWRITEPAGE_ACTIVATE

[Andrew Morton]

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 02, 2005 at 11:43:12PM -0800, Joel Becker wrote:
> > > Looks sane to me.   Can you carry this in the ocfs2 tree?
> > 
> > 	No problem.  Give us a day or two to merge the changes to our
> > main trees.
> 
> I think I disagree with Andew here.  Having a core patch separate
> from a new drivers/filesystem/etc.. is always a good idea.  It makes
> reviewing a lot easier and allows independant handling, e.g. merging it
> earlier than the new driver for some reason - as happened for example
> with the clear_inode changes we needed earlier for ocfs or the pagevec
> exports that came in via the reiser4 patches but were needed in mainline
> for cifs now.

Yes, that's better from a code staging/reviewing pov.

But there's a practical problem: if I put the patch in -mm for testing, and
the ocfs2 guys put the patch into their git tree for their testing, I get
rejects.  So I drop the core patch from -mm again.  If the ocfs guys _dont_
put the patch into their tree, they need to add this additional patch for
their testing.  It's all screwed up.

So for both -mm and for the ocfs2 team, leaving the patch in the ocfs2 git
tree is the most convenient place for it.

Obviously, merging it into Linus's tree will fix up everyone's patching
problems, but it has no users at this time...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/