Re: [Patch] add AOP_TRUNCATED_PAGE, prepend AOP_ toWRITEPAGE_ACTIVATE

From: Andrew Morton
Date: Wed Nov 02 2005 - 21:45:56 EST


Zach Brown <zach.brown@xxxxxxxxxx> wrote:
>
> readpage(), prepare_write(), and commit_write() callers are updated to
> understand the special return code AOP_TRUNCATED_PAGE in the style of
> writepage() and WRITEPAGE_ACTIVATE. AOP_TRUNCATED_PAGE tells the caller that
> the callee has unlocked the page and that the operation should be tried again
> with a new page. OCFS2 uses this to detect and work around a lock inversion in
> its aop methods. There should be no change in behaviour for methods that don't
> return AOP_TRUNCATED_PAGE.
>
> WRITEPAGE_ACTIVATE is also prepended with AOP_ for consistency and they are
> made enums so that kerneldoc can be used to document their semantics.

Looks sane to me. Can you carry this in the ocfs2 tree?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/