Re: [PATCH 1/2] swsusp: reduce code duplication (was: Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c)

[Pavel Machek]

Hi!

> > > > Speaking of simplifications and having seen your code I hope you will agree with
> > > > the appended patch against vanilla 2.6.14-git3 (it reduces the duplication of code,
> > > > and replaces swsusp_pagedir_relocate with a simpler mechanism).
> > > 
> > > ...and also moves stuff around in a way
> > > 
> > > a) I don't like
> > > 
> > > and
> > > 
> > > b) is almost impossible to review
> > 
> > OK, I'll try to split it into two patches to make it cleaner.
> 
> The first patch is appended, the next one will be in the reply to this message.
> 
> The changes made by the appended patch are necessary for the relocation
> simplification in the next patch.  Still, the changes allow us to drop
> check_pagedir() and make get_safe_page() be a one-line wrapper around
> alloc_image_page() (get_safe_page() goes to snapshot.c, because
> alloc_image_page() is static and it does not make sense to export
> it).

ACK.
								Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/