[PATCH] Fixes for RCU handling of sighand_struct

From: Paul E. McKenney
Date: Tue Nov 01 2005 - 00:51:59 EST


Hello!

Some fixes to RCU usage for sighand_struct, adding a couple of needed
rcu_assign_pointer() calls.

Signed-off-by: <paulmck@xxxxxxxxxx>

---

diff -urpNa linux-2.6.14-rc5-rt5/fs/exec.c linux-2.6.14-rc5-rt5-sighandRCUfix/fs/exec.c
--- linux-2.6.14-rc5-rt5/fs/exec.c 2005-10-24 05:59:08.000000000 -0700
+++ linux-2.6.14-rc5-rt5-sighandRCUfix/fs/exec.c 2005-10-31 15:38:02.000000000 -0800
@@ -777,7 +777,7 @@ no_thread_group:
spin_lock(&oldsighand->siglock);
spin_lock(&newsighand->siglock);

- current->sighand = newsighand;
+ rcu_assign_pointer(current->sighand, newsighand);
recalc_sigpending();

spin_unlock(&newsighand->siglock);
diff -urpNa linux-2.6.14-rc5-rt5/kernel/fork.c linux-2.6.14-rc5-rt5-sighandRCUfix/kernel/fork.c
--- linux-2.6.14-rc5-rt5/kernel/fork.c 2005-10-24 05:59:08.000000000 -0700
+++ linux-2.6.14-rc5-rt5-sighandRCUfix/kernel/fork.c 2005-10-31 15:35:14.000000000 -0800
@@ -816,7 +816,7 @@ static inline int copy_sighand(unsigned
return 0;
}
sig = kmem_cache_alloc(sighand_cachep, GFP_KERNEL);
- tsk->sighand = sig;
+ rcu_assign_pointer(tsk->sighand, sig);
if (!sig)
return -ENOMEM;
spin_lock_init(&sig->siglock);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/