Re: [linux-usb-devel] Re: Commit "[PATCH] USB: Always dousb-handoff" breaks my powerbook

[Benjamin Herrenschmidt]

On Tue, 2005-11-01 at 15:52 +1100, Paul Mackerras wrote:
> David Brownell writes:
> 
> > Maybe you should first pay attention to what I pointed out:  that
> > the problem reports I've seen have ONLY been on PPC systems.
> 
> Well, there is a problem in the code which is clearly visible just by
> inspection: that it is touching a pci device without having called
> pci_enable_device on it.  That is well known to cause problems on many
> platforms, and it is not guaranteed to work on any platform.
> 
> With a clearly visible bug like that in there, it doesn't matter what
> platform(s) the problem is reported on.

Yup, though I agree that considering the purpose of that code, it might
make sense for it to just "peek" to check if the device was enabled
rather than force-enabling it. If it was not, there is obviously no
handoff to do from the BIOS.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/