Re: [xfs-masters] [2.6 patch] fs/xfs/: possible cleanups

From: Christoph Hellwig
Date: Sun Oct 30 2005 - 18:31:29 EST

On Sun, Oct 30, 2005 at 09:02:42PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global functions static
> - xfs_trans_item.c should #include "xfs_trans_priv.h" for getting the
> prototypes of it's global functions.
> Please review which of these changes do make sense.

I applied the things from your last patch that we could apply, but some
symbols can't be made static because the parts of codebase are shared with
userland and Linux 2.4 where they need to be global. I'll go through
this patch again and will apply the parts that we can do - there seems
to be lots of new stuff vs last time.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at