Re: [PATCH] pci device wakeup flags

From: Andrew Morton
Date: Fri Oct 28 2005 - 05:52:00 EST


Greg KH <gregkh@xxxxxxx> wrote:
>
> [PATCH] pci device wakeup flags
>
> This patch teaches "pci_dev" about the new driver model wakeup support:
>
> - It marks devices as supporting wakeup when "can issue PME#" is
> listed in its PCI PM capability.
>
> - pci_enable_wake() refuses to enable wake if that's been disabled
> (e.g. through sysfs).
>
> NOTE that a recent patch changed PCI probing, and this reverts part
> of that change ... so that driver model initialization is again done
> before the PCI setup.
>
> (One issue is that the driver model "init + add == register" pattern isn't
> being used inside PCI ... and that probe change worsened the problem by
> making "add" do some "init" too. Maybe PCI should match the driver model
> more closely, and just grow a new "pci_dev_init" function.)

This is the patch which I've been religiously dropping from -mm because it
kills my Mac G5. What are we doing merging this?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/