Re: [patch 1/1] export cpu_online_map

From: Andrew Morton
Date: Thu Oct 27 2005 - 04:37:08 EST


Paul Jackson <pj@xxxxxxx> wrote:
>
> Andrew wrote:
> > > Since bk no longer works for me, I have no idea how to access any
> > > history prior to about 2.6.12-rc2. Ugh.
> >
> > There's still bkbits.net:
> >
> > http://linux.bkbits.net:8080/linux-2.6/...
>
> Ok - that helps. Thanks.
>
> There is also an hg (mercurial) web based Linux history at:
>
> http://www.kernel.org/hg/linux-2.6/
>
> I still don't see something I can download into a local
> hg or git repository -- if a lurker knows how that is done,
> I'd be glad to know.
>

I think there are ways of getting the entire kernel history in git too.

I usually just grep my patches directory, actually. <looks>. <egad>.
27,000 of them.

>
> > Seems silly to use cpu_online_map to test for `1'?
>
> Yeah - agreed. The include/linux/cpumask.h stuff hardcodes
> the UP (NR_CPUS==1) code to plain old 0's and 1's. This
> macro should do so as well.
>
> I just sent a patch.
>

Sweet, thanks. Perhaps we can remove cpu_online_map from UP builds soon -
it's really wrong to have it there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/