Re: RFC: Cleanup / small fixes to hugetlb fault handling

From: 'David Gibson'
Date: Wed Oct 26 2005 - 19:21:18 EST


On Wed, Oct 26, 2005 at 01:12:30PM -0700, Chen, Kenneth W wrote:
> David Gibson wrote on Tuesday, October 25, 2005 7:49 PM
> > - find_lock_huge_page() didn't, in fact, lock the page if it newly
> > allocated one, rather than finding it in the page cache already. As
> > far as I can tell this is a bug, so the patch corrects it.
>
> add_to_page_cache will lock the page if it was successfully added to the
> address space radix tree. I don't see a bug that you are seeing.

Ah, so it does. Thought I might be missing something.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/people/dgibson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/