Re: 2.6.14-rc5-mm1

From: Andrew Morton
Date: Tue Oct 25 2005 - 12:59:17 EST


Badari Pulavarty <pbadari@xxxxxxxxx> wrote:
>
> On Mon, 2005-10-24 at 14:16 -0700, Andrew Morton wrote:
> ..
> >
> > qla2x00_probe_one() has called qla2x00_free_device() and
> > qla2x00_free_device() has locked up in
> > wait_for_completion(&ha->dpc_exited);
> >
> > Presumably, ha->dpc_exited is not initialised yet.
> >
> > The first `goto probe_failed' in qla2x00_probe_one() will cause
> > qla2x00_free_device() to run wait_for_completion() against an uninitialised
> > completion struct. Because ha->dpc_pid will be >= 0.
> >
> > This patch might fix the lockup, but if so, qla2x00_iospace_config()
> > failed. Please debug that a bit for us?
>
> Yes. This patch helped. Due to power failures, my disk trays are
> powered off. qla2x00_iospace_config() is failing and causing the
> panic on -mm kernel. For odd reasons, older -mm kernels & mainline
> kernels doesn't panic.

OK, thanks. Andrew seems offline and this patch is sufficiently obvious
that I think I'll just jam it into 2.6.14...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/