Re: [PATCH 2/8] VFS: per inode statfs (core)

From: Al Viro
Date: Mon Oct 24 2005 - 23:25:30 EST


On Mon, Oct 24, 2005 at 06:55:19PM +0200, Miklos Szeredi wrote:
> This patch adds a statfs method to inode operations. This is invoked
> whenever the dentry is available (not called from sys_ustat()) and the
> filesystem implements this method. Otherwise the normal
> s_op->statfs() will be called.
>
> This change is backward compatible, but calls to vfs_statfs() should
> be changed to vfs_dentry_statfs() whenever possible.

What the fuck for? statfs() returns data that by definition should
not depend on inode within a filesystem.

NAK, and if FUSE needs that for something, it's *badly* misdesigned.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/