Re: [RFC] gfp flags annotations

[Greg KH]

On Thu, Oct 06, 2005 at 09:15:34PM +0100, Al Viro wrote:
> Speaking of that...  IMO we should do the following:
> 
> a) typedef unsigned int __nocast gfp_t;
> b) replace __nocast uses for gfp flags with gfp_t - it gives exactly the same
> warnings as far as sparse is concerned, doesn't change generated code and
> documents what's going on far better.  If we are using __nocast for anything
> else - sure, let it stay.
> c) then replace __nocast in declaration of gfp_t with __bitwise [*], add
> force cast to gfp_t to definitions of __GFP_... and deal with resulting
> warnings.
> 
> Objections?

None from me, this will be a good thing to have.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/