Re: [PATCH 2.6.14-rc2 0/2] libata: Marvell SATA support (v0.23-0.24)

[Brett Russ]

Jeff Garzik wrote:
> Staring at the docs a bit, I notice that the 50xx and 60xx have SATA 
> S{status,control,error} registers at different locations.


Yes and also even some registers that are at the same location have 
changed bit definitions.  Aye caramba.

Best solution will probably be to create separate enums for each chip 
generation, in addition to a common enum, and point to the relevant one 
based on the chip identifier.

No surprise we're seeing so many problems.  I have just not spent any 
time at all on 5xxx.  Probably should yank it from the pci device table 
for now.

BR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/