Re: clone: I'm only doing a max of 256 requests

From: Junio C Hamano
Date: Wed Oct 05 2005 - 16:39:15 EST


Junio C Hamano <junkio@xxxxxxx> writes:

> 1. As a stop gap measure, so that your Linux kernel work can
> continue, please bump MAX_NEEDS definition in upload-pack.c
> from 256 to a bit higher. That controls the number of
> 40-letter SHA1 given to underlying rev-list via execvp(), so
> it cannot be _too_ big like 1M, lest it exceeds the exec
> argument buffer limit.

Hmph. I was reading linux-2.6/fs/exec.c::copy_strings(), but I
do not see any such size limit (other than exceeding the total
machine memory size, probably reported by alloc_page() failing)
imposed there. Am I looking at the wrong place?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/