RE: [PATCH 5/7] HPET-RTC: disable interrupt when no longer needed

[Pallipadi, Venkatesh]

>-----Original Message-----
>From: aezr4@xxxxxxxxxxxxxxxxxxxxxxxx 
>[mailto:aezr4@xxxxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Clemens Ladisch
>Sent: Wednesday, September 28, 2005 11:30 PM
>To: Pallipadi, Venkatesh
>Cc: linux-kernel@xxxxxxxxxxxxxxx; Bob Picco
>Subject: Re: [PATCH 5/7] HPET-RTC: disable interrupt when no 
>longer needed
>
>Venkatesh Pallipadi wrote:
>> On Wed, Sep 28, 2005 at 09:12:26AM +0200, Clemens Ladisch wrote:
>> > When the emulated RTC interrupt is no longer needed, we 
>better disable
>> > it; otherwise, we get a spurious interrupt whenever the timer has
>> > rolled over and reaches the same comparator value.
>> >
>> > Having a superfluous interrupt every five minutes doesn't 
>hurt much,
>> > but it's bad style anyway.  ;-)
>>
>> Do you really see the interrupt every five minutes once RTC 
>is disabled.
>
>Yes; at least on my Intel chipset.  ;-)
>
>> I had assumed while in one-shot interrupt mode, HPET would 
>automatically unarm
>> after generating the interrupt, so that we won't get 
>interrupts any more.
>
>The spec never mentions this.  What it mentions is that it was
>designed so that it can be implemented in as few gates as possible.
>

Verified in the latest version of the SPEC. It indeed says that
one shot timer can happen more than once when the 32 bit counter 
wraps around. So, this patch is also required. Thanks for all the fixes.

Andrew, Please pick this one as well.

Thanks,
venki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/