Re: [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback

[Dave Hansen]

On Wed, 2005-10-05 at 18:20 +0100, Mel Gorman wrote:
> Changed to
> 
> for (i = 0; (alloctype = fallback_list[i]) != -1; i++) {
> 
> where i is declared a the start of the function. It's essentially the same
> as how we move through the zones fallback list so should seem familiar. Is
> that better?

Yep, at least I understand what it's doing :)

One thing you might consider is not doing the assignment in the for()
body:

	for (i = 0; fallback_list[i] != -1; i++) {
		alloctype = fallback_list[i];
		...

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/