Re: [PATCH] Free swap suspend from depending upon PageReserved.

From: Rafael J. Wysocki
Date: Wed Oct 05 2005 - 07:54:17 EST


Hi,

On Wednesday, 5 of October 2005 14:12, Pavel Machek wrote:
> Hi!
>
> > Here's the patch we've previously discussed, which removes the
> > dependancy of swap suspend on PageReserved.
>
> This ends up in Linus' changelog, so "we've previously discussed"
> is not okay here. Missing signed-off. What is benefit of this?
>
> swsusp part looks okay, but will Andrew like the generic part? I guess
> I'd prefer to postpone this one (unless we are last user of
> PageReserved) -- I do not see too big benefit and there's potential
> for breakage.

Basically, what it does is to make swsusp avoid saving (and restoring)
non-RAM pages (like the ISA hole, BIOS etc.). I think it is a nice thing
to do and it does not hurt anyone (it only clears and/or sets PG_nosave
at some places). However, if we decide to do this for i386, it should
also be done for x86-64.

Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/