Re: [PATCH 1/7] ppc64: EEH typos, include files, macros, whitespace

From: Paul Mackerras
Date: Wed Oct 05 2005 - 06:23:54 EST


Linas writes:

> 01-eeh-minor-cleanup.patch

Some trivial comments on a trivial patch... :)

> - printk(KERN_WARNING "PCI: no pci dn found for dev=%s\n",
> - pci_name(dev));
> + printk(KERN_WARNING "PCI: no pci dn found for dev=%s\n", pci_name(dev));

This makes the line go over 80 columns, which seems unnecessary.

> - * @token i/o token, should be address in the form 0xE....
> + * @token i/o token, should be address in the form 0xA....

I think the virtual addresses we get from ioremap these days start
with 0xD00008...

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/