Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss

[Jay Lan]

Hugh Dickins wrote:
> And thanks for your patch, which I've factored in with Frank's, and come
> come up with the one below, against 2.6.14-rc2-mm2.  Which uses no CONFIG
> flag: I think we're enough out of the fast paths that it's not needed.
>
> See comment in fs/proc/task_mmu.c for the principle.  Could maintain
> hiwater_vm straightforwardly, but I think it's easier to remember if
> we handle them both in the same way.
>
> I did look into doing the total_vm increment and calling vm_stat_account
> in insert_vm_struct, but concluded it solved no particular problem, and
> raised some questions (where architectures, notably ia64, have special
> vmas which they may have good reason to leave out of total_vm).
>
> I haven't cross-checked the mm_struct cacheline rearrangement yet,
> it looks plausible, but could easily turn out to straddle boundaries.
>
> Christoph, Frank, Jay: does this patch look like it fits your needs?

I am building a kernel with your patch and am going to run some test
to compare the statistics.

Thanks,
 - jay

>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/